Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(examples): Adding Serverless Example #3621

Merged
merged 10 commits into from
Feb 13, 2024
Merged

chore(examples): Adding Serverless Example #3621

merged 10 commits into from
Feb 13, 2024

Conversation

xoscar
Copy link
Contributor

@xoscar xoscar commented Feb 9, 2024 •
edited
Loading

This PR adds the serverless example to the examples folder alongside a recipe for the docs website

Changes

  • Adds serverless example
  • Adds new recipe

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Loom video

@vercel Vercel
Copy link

vercel bot commented Feb 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tracetest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2024 2:36pm

@xoscar xoscar marked this pull request as ready for review February 9, 2024 18:29
@xoscar xoscar self-assigned this Feb 9, 2024
adnanrahic
adnanrahic reviewed Feb 12, 2024
View reviewed changes
Copy link
Contributor

@adnanrahic adnanrahic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some ideas about improvements.

docs/docs/examples-tutorials/recipes/testing-lambda-functions-with-opentelemetry-tracetest.mdx Show resolved Hide resolved
@xoscar
Update docs/docs/examples-tutorials/recipes/testing-lambda-functions-…
f8d589f 
…with-opentelemetry-tracetest.mdx

Co-authored-by: Adnan Rahić <[email protected]>
@xoscar xoscar merged commit 8adaa72 into main Feb 13, 2024
39 checks passed
@xoscar xoscar deleted the chore-serverless-example branch February 13, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfermi jfermi jfermi approved these changes

@adnanrahic adnanrahic adnanrahic approved these changes

@schoren schoren Awaiting requested review from schoren

@kdhamric kdhamric Awaiting requested review from kdhamric

@mathnogueira mathnogueira Awaiting requested review from mathnogueira

@jorgeepc jorgeepc Awaiting requested review from jorgeepc

@danielbdias danielbdias Awaiting requested review from danielbdias

Assignees

@xoscar xoscar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xoscar @adnanrahic @jfermi